fix(dag): close two CI-only failures from the DAG-LOC-01 merge - #267
Merged
Conversation
…on authority Two CI-only failures from the DAG-LOC-01 merge (PR #266), both outside the PR's gate set: - license-scope (linux unit job) flagged packages/opencode/src/dag/location.ts as an AGPL source without SPDX headers — the file was created without the repository's copyright banner. Add the standard two-line header. - bootstrap-dag-wiring 'recovers a persisted workflow' seeds its WorkflowTable row via raw SQL without the new directory column, so the fail-closed NULL stamp policy (a NULL stamp matches no instance) leaves the workflow unadopted and the scheduler never starts. Stamp the seed with the instance's directory (same sibling-test idiom as dag-wake-integration). Root cause for both: the PR's verify gate ran test/dag test/goal test/tool but not test/project or the core license manifest; the follow-up gate list should include them. Gates: core license-scope 5/5, opencode bootstrap-dag-wiring 1/1, test/dag test/goal 607/0, lint 4849/4852, typecheck clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two failures surfaced by the dev full-test run (31830294131) after merging #266, both outside that PR's gate set:
packages/opencode/src/dag/location.tswas created without the repository's SPDX copyright banner — AGPL source missing headers.recovers a persisted workflow: the test seeds its WorkflowTable row via raw SQL without the newdirectorycolumn, so the fail-closed NULL-stamp policy (a NULL stamp matches no instance) leaves the workflow unadopted — "bootstrap did not start the DAG scheduler".Fixes: standard SPDX header; stamp the seed with the instance directory (same sibling-test idiom as dag-wake-integration).
Root cause of both escaping #266: its verify gates ran
test/dag test/goal test/toolbut nottest/projector the core license manifest.Test plan
bun test test/license-scope.test.ts5/5bun test test/project/bootstrap-dag-wiring.test.ts1/1 (was failing pre-fix)bun test test/dag test/goal607/0bun run lint4849/4852